Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [rhel_for_edge] Update docstring to make it more readable #3531

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

psachin
Copy link
Contributor

@psachin psachin commented Sep 22, 2022

This is a follow-up of #3526 to make the docstring more readable.

Signed-off-by: Sachin Patil [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

@psachin psachin requested a review from jobselko September 22, 2022 07:56
@psachin psachin self-assigned this Sep 22, 2022
@psachin psachin changed the title Update docstring to make it more readable feat: [rhel_for_edge] Update docstring to make it more readable Sep 22, 2022
Copy link
Contributor

@jobselko jobselko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

insights/combiners/rhel_for_edge.py Outdated Show resolved Hide resolved
insights/combiners/rhel_for_edge.py Show resolved Hide resolved
@psachin psachin force-pushed the update_rhel_edge_docstring branch from 3ebefaf to 6e2aade Compare September 26, 2022 06:30
@psachin psachin merged commit 534888a into master Sep 27, 2022
xiangce pushed a commit that referenced this pull request Sep 29, 2022
Signed-off-by: Sachin Patil <[email protected]>

Signed-off-by: Sachin Patil <[email protected]>
(cherry picked from commit 534888a)
@xiangce xiangce deleted the update_rhel_edge_docstring branch May 5, 2023 07:44
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Sachin Patil <[email protected]>

Signed-off-by: Sachin Patil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants