Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bz-2126966: use SIGTERM for rpm instead of SIGKILL #3524

Merged
merged 0 commits into from
Sep 20, 2022
Merged

fix: bz-2126966: use SIGTERM for rpm instead of SIGKILL #3524

merged 0 commits into from
Sep 20, 2022

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Sep 15, 2022 •
edited
Loading

Signed-off-by: Xiangce Liu [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Fix bz-2126966, the "rpm/yum/dnf" related command should use "SIGTERM" instead of the default "SIGKILL".

  • also modified the "rpm_ostree_status"

@xiangce xiangce requested review from bfahr and jobselko September 15, 2022 08:12
jobselko
jobselko approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@jobselko jobselko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! I am sorry I did not check the usage of similar commands in insights-core and thus made this mistake.

@bfahr bfahr merged commit 6fc4e78 into master Sep 20, 2022
bfahr pushed a commit that referenced this pull request Sep 20, 2022
@xiangce @bfahr
fix: bz-2126966: use SIGTERM for rpm instead of SIGKILL (#3524)
e338a54 
Signed-off-by: Xiangce Liu <[email protected]>

Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit 6fc4e78)
@xiangce xiangce deleted the rpm_2126966 branch September 21, 2022 00:52
xiangce added a commit that referenced this pull request Sep 6, 2024
@xiangce
fix: bz-2126966: use SIGTERM for rpm instead of SIGKILL (#3524)
ecc5475 
Signed-off-by: Xiangce Liu <[email protected]>

Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobselko jobselko jobselko approved these changes

@bfahr bfahr bfahr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiangce @bfahr @jobselko