fix: Removing extraneous space inserted during refactoring commit 894484a

[mike-kingsbury]

… Code was moved to a new function, and a space was added to the split. bz#2126155

All Pull Requests:

Check all that apply:

• [ x ] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
• [ x ] Is this PR to correct an issue?
• Is this PR an enhancement?

Complete Description of Additions/Changes:

Reverting a change that introduced a space into a .split(','). The space broke the functionality of the Insights client when using NO_PROXY with multiple items.

[xiangce]

I'm just wondering if we could add a test case for this? It seems an issue that can be detected by a sufficient test.

[mike-kingsbury]

I'm just wondering if we could add a test case for this? It seems an issue that can be detected by a sufficient test.

Give me a couple of minutes, you're correct it should be testable.

[xiangce]

@mike-kingsbury - Thanks for the update. It looks good to me. @ahitacat, please have a look, if it is also good for you, I think we can merge and release it today.

[ahitacat]

In that case it would fail with no_proxy values separated by comma and space. Like the one is given in the bug report This no_proxy function get the the value from env or from rhsm. So let's try to support bot of them.

[ahitacat]

Also it could be useful to add a check under test_get_no_proxy_rhsm that tests when no_proxy has values separated by comma and space.

    with patch.dict(os_environ, {"HTTPS_PROXY": "env.proxy.example.com", "NO_PROXY": "example.com, redhat.com"}, clear=True):
        connection.get_proxies()
    assert connection.proxies == {'https': 'env.proxy.example.com'}

[ahitacat]

This changes looks great and it can be merged. Thanks @mike-kingsbury for open and fix the bug.