Remove usage of reregistration and deprecate cli-option #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahitacat
added
the
client
|
LGTM! |
strider
requested changes
Sep 20, 2022
insights/client/config.py
Outdated
| @@ -326,7 +326,7 @@ def _core_collect_default(): | |||
| 'reregister': { | |||
| 'default': False, | |||
| 'opt': ['--force-reregister'], | |||
| 'help': 'Forcefully reregister this machine to Red Hat. Use only as directed.', | |||
| 'help': argparse.SUPPRESS, | |||
There was a problem hiding this comment.
As we are in deprecation mode, I will not silence that option from argparse now. But I would suggest adding the deprecation message, announcing the ineffectiveness of that latter and its future removal.
There was a problem hiding this comment.
Agree, I have added a new message
ahitacat
changed the title
Signed-off-by: ahitacat <[email protected]>
ahitacat
changed the title
subpop
pushed a commit
that referenced
this pull request
Dec 7, 2022
Signed-off-by: ahitacat <[email protected]>
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: ahitacat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahitacat [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Working on deprecate --force-reregistration client option. This option will be deprecate in favor of the explicit running of
insights-client --unregisterandinsights-client --register. This work is part of the improvement of the re-registration safeguard [RHIN-500]Resolves: #rhbz2071082