Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New parser for CpuSMTControl and tests update #3521

Merged
merged 2 commits into from
Sep 15, 2022
Merged

New parser for CpuSMTControl and tests update #3521

merged 2 commits into from
Sep 15, 2022

Conversation

jobselko
Copy link
Contributor

@jobselko jobselko commented Sep 12, 2022 •
edited
Loading

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

insights-core-assets already has the cpu_smt_control entries, so no further changes are necessary.

@jobselko
Add CpuSMTControl parser
1e31865 
Signed-off-by: Jitka Obselkova <[email protected]>
@jobselko
Rework current tests
f6bbdf5 
Signed-off-by: Jitka Obselkova <[email protected]>
@jobselko jobselko requested review from psachin and xiangce September 12, 2022 16:04
xiangce
xiangce approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@xiangce xiangce left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the update.

@psachin psachin merged commit c0c3fb8 into RedHatInsights:master Sep 15, 2022
psachin pushed a commit that referenced this pull request Sep 15, 2022
@jobselko
New parser for CpuSMTControl and tests update (#3521)
b2bcbc2 
* Add CpuSMTControl parser

Signed-off-by: Jitka Obselkova <[email protected]>

* Rework current tests

Signed-off-by: Jitka Obselkova <[email protected]>

Signed-off-by: Jitka Obselkova <[email protected]>
(cherry picked from commit c0c3fb8)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
@jobselko
New parser for CpuSMTControl and tests update (#3521)
73a472c 
* Add CpuSMTControl parser

Signed-off-by: Jitka Obselkova <[email protected]>

* Rework current tests

Signed-off-by: Jitka Obselkova <[email protected]>

Signed-off-by: Jitka Obselkova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangce xiangce xiangce approved these changes

@psachin psachin psachin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jobselko @psachin @xiangce