Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add spec "satellite_enabled_features" back #3517

Merged
merged 3 commits into from
Sep 15, 2022
Merged

feat: Add spec "satellite_enabled_features" back #3517

merged 3 commits into from
Sep 15, 2022

Conversation

huali027
Copy link
Contributor

@huali027 huali027 commented Sep 8, 2022

Add spec "satellite_enabled_features" back

  • It is needed by a new rule, so add it back

Signed-off-by: Huanhuan Li [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

* It is needed by a new rule, so add it back

Signed-off-by: Huanhuan Li <[email protected]>
@huali027
Copy link
Contributor Author

huali027 commented Sep 8, 2022

@xiangce Please help to review, thanks.

insights/specs/insights_archive.py Outdated Show resolved Hide resolved
@psachin psachin merged commit c3adb62 into RedHatInsights:master Sep 15, 2022
psachin pushed a commit that referenced this pull request Sep 15, 2022
* feat: Add spec "satellite_enabled_features" back

* It is needed by a new rule, so add it back

Signed-off-by: Huanhuan Li <[email protected]>

* Adjust the place of "satellite_enabled_features"

Signed-off-by: Huanhuan Li <[email protected]>

* Remove useless line since it depends on core collection

Signed-off-by: Huanhuan Li <[email protected]>

Signed-off-by: Huanhuan Li <[email protected]>
(cherry picked from commit c3adb62)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* feat: Add spec "satellite_enabled_features" back

* It is needed by a new rule, so add it back

Signed-off-by: Huanhuan Li <[email protected]>

* Adjust the place of "satellite_enabled_features"

Signed-off-by: Huanhuan Li <[email protected]>

* Remove useless line since it depends on core collection

Signed-off-by: Huanhuan Li <[email protected]>

Signed-off-by: Huanhuan Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants