fix: support InstanceType in saphostctrl #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
changed the title
bfahr
requested changes
Sep 6, 2022
| @@ -142,11 +143,11 @@ def test_saphostctrl_docs(): | |||
|
|
|||
| def test_saphostctrl(): | |||
| sap = SAPHostCtrlInstances(context_wrap(SAPHOSTCTRL_HOSTINSTANCES_GOOD)) | |||
| assert len(sap) == 10 | |||
| assert sap.data[-2]['SapVersionInfo'] == '749, patch 401, changelist 1806777' | |||
There was a problem hiding this comment.
@xiangce it might be good to leave this test in too for data since you added it as a property to maintain backward compatibility.
There was a problem hiding this comment.
Fixed.
And fixed the test data in rules per the parser.
Thanks for checking!
There was a problem hiding this comment.
@bfahr - The items you pointed out were fixed, I went ahead and merged this PR. For further issues, please let me know.
xiangce
added a commit
that referenced
this pull request
Sep 8, 2022
* feat: support InstanceType in saphostctrl Signed-off-by: Xiangce Liu <[email protected]> * fix and test the full_type Signed-off-by: Xiangce Liu <[email protected]> * Use full_type only to check function_instances Signed-off-by: Xiangce Liu <[email protected]> - Add 'Diagnostic Agents' * fix typos * revert the test cases of .data * revert the doc of attr 'instances' Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit b965215)
This was referenced Sep 20, 2022
xiangce
added a commit
that referenced
this pull request
Sep 6, 2024
* feat: support InstanceType in saphostctrl Signed-off-by: Xiangce Liu <[email protected]> * fix and test the full_type Signed-off-by: Xiangce Liu <[email protected]> * Use full_type only to check function_instances Signed-off-by: Xiangce Liu <[email protected]> - Add 'Diagnostic Agents' * fix typos * revert the test cases of .data * revert the doc of attr 'instances' Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiangce Liu [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
From BZ-1969572, the "InstanceType" should be used as the identifier for SAP
function_instance