Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert the httpd_on_nfs datasource spec #3509

Merged
merged 0 commits into from
Sep 1, 2022
Merged

fix: Revert the httpd_on_nfs datasource spec #3509

merged 0 commits into from
Sep 1, 2022

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Aug 30, 2022 •
edited
Loading

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

@xiangce xiangce changed the title Revert the httpd_on_nfs datasource spec fix: Revert the httpd_on_nfs datasource spec Aug 30, 2022
@xiangce xiangce requested a review from chenlizhong August 30, 2022 03:27
@xiangce xiangce merged commit 4575b4a into master Sep 1, 2022
@xiangce xiangce deleted the http_nfs branch September 1, 2022 01:44
xiangce added a commit that referenced this pull request Sep 1, 2022
@xiangce
fix: Revert the httpd_on_nfs datasource spec (#3509)
7146a0c 
* fix: Revert spec httpd_on_nfs
* use ProcMounts parser instead of Mounts combiner
* ensure vers can be checked
Signed-off-by: Xiangce Liu <[email protected]>

* fix test of py2
Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit 4575b4a)
xiangce added a commit that referenced this pull request Sep 6, 2024
@xiangce
fix: Revert the httpd_on_nfs datasource spec (#3509)
26d6155 
* fix: Revert spec httpd_on_nfs
* use ProcMounts parser instead of Mounts combiner
* ensure vers can be checked
Signed-off-by: Xiangce Liu <[email protected]>

* fix test of py2
Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfahr bfahr bfahr approved these changes

@chenlizhong chenlizhong Awaiting requested review from chenlizhong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpd_on_nfs datasource is missed but there are rules depending on it
2 participants
@xiangce @bfahr