Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure full path when using timeout command #3508

Merged
merged 0 commits into from
Sep 8, 2022
Merged

Ensure full path when using timeout command #3508

merged 0 commits into from
Sep 8, 2022

Conversation

bfahr
Copy link
Contributor

@bfahr bfahr commented Aug 26, 2022

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

  • util/subproc was already using which to get the full path for timeout, but the command spec was not. This change uses the which util to ensure the full path is obtained for the timeout command
  • Fix Use absolute path to timeout command #1130

Signed-off-by: Bob Fahr [email protected]

ryan-blakley
ryan-blakley approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@ryan-blakley ryan-blakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bfahr bfahr requested a review from subpop August 30, 2022 18:00
@bfahr
Copy link
Contributor Author

bfahr commented Aug 30, 2022

@subpop this issue was mentioned in RHCLOUD-2104 Jira that was closed this week. There are two places where the timeout command was used, one in core and one in the client. I went ahead and checked core which was already fixed, and then checked the client and it was not fixed. So this is the client fix only.

@subpop
Copy link
Collaborator

subpop commented Aug 30, 2022

Seems reasonable to me. @Glutexo any concerns or objections?

@xiangce
Copy link
Contributor

xiangce commented Sep 5, 2022

@Glutexo - Have a look at this PR, please. If no responses/objections, we'll merge it in the next release.

@xiangce xiangce merged commit c101690 into master Sep 8, 2022
@xiangce xiangce deleted the fix_timeout_path branch September 8, 2022 02:19
xiangce pushed a commit that referenced this pull request Sep 8, 2022
@bfahr @xiangce
Ensure full path when using timeout command (#3508)
9fcaa85 
* util/subproc was already using which to get the full path for timeout, but the command spec was not.  This change uses the which util to ensure the full path is obtained for the timeout command
* Fix #1130

Signed-off-by: Bob Fahr <[email protected]>
(cherry picked from commit c101690)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
@bfahr
Ensure full path when using timeout command (#3508)
bf77042 
* util/subproc was already using which to get the full path for timeout, but the command spec was not.  This change uses the which util to ensure the full path is obtained for the timeout command
* Fix #1130

Signed-off-by: Bob Fahr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangce xiangce xiangce approved these changes

@ryan-blakley ryan-blakley ryan-blakley approved these changes

@subpop subpop Awaiting requested review from subpop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use absolute path to timeout command
4 participants
@bfahr @subpop @xiangce @ryan-blakley