Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue calling collect from cli #3506

Merged
merged 0 commits into from
Aug 30, 2022
Merged

Fix issue calling collect from cli #3506

merged 0 commits into from
Aug 30, 2022

Conversation

bfahr
Copy link
Contributor

@bfahr bfahr commented Aug 25, 2022

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Signed-off-by: Bob Fahr [email protected]

@bfahr bfahr force-pushed the collect_main_args branch from 0fe94f2 to bc79ca2 Compare August 25, 2022 18:26
@ryan-blakley ryan-blakley merged commit 0d7b7f0 into master Aug 30, 2022
ryan-blakley pushed a commit that referenced this pull request Aug 30, 2022
* When collect is called from the cli, the malware datasource calls client configuration which parses the collect args and fails.
* This PR removes the args after parsing to avoid the failure.
* Fix #3505

Signed-off-by: Bob Fahr <[email protected]>

Signed-off-by: Bob Fahr <[email protected]>
(cherry picked from commit 0d7b7f0)
@ryan-blakley ryan-blakley deleted the collect_main_args branch August 30, 2022 18:30
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* When collect is called from the cli, the malware datasource calls client configuration which parses the collect args and fails.
* This PR removes the args after parsing to avoid the failure.
* Fix #3505

Signed-off-by: Bob Fahr <[email protected]>

Signed-off-by: Bob Fahr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When invoking collect cli, args are being parsed by client and failing
2 participants