Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soscleaner fix #3502

Merged
merged 0 commits into from
Sep 19, 2022
Merged

Soscleaner fix #3502

merged 0 commits into from
Sep 19, 2022

Conversation

Glutexo
Copy link
Collaborator

@Glutexo Glutexo commented Aug 24, 2022

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

@Glutexo Glutexo requested a review from ahitacat August 24, 2022 15:30
Copy link
Contributor

@ahitacat ahitacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, once the flake8 is fixed smile I have manually test it and can resolve the IP Obfuscation problem.

@ahitacat ahitacat added the client These issues represent work to be done by the "client" team. label Aug 25, 2022
@Glutexo
Copy link
Collaborator Author

Glutexo commented Sep 12, 2022

test this please

@Glutexo
Copy link
Collaborator Author

Glutexo commented Sep 12, 2022

test me

@Glutexo Glutexo requested a review from ahitacat September 12, 2022 17:48
@xiangce xiangce merged commit a3f6770 into RedHatInsights:master Sep 19, 2022
xiangce pushed a commit that referenced this pull request Sep 19, 2022
* Move results object to ReportItem

Signed-off-by: Štěpán Tomsa <[email protected]>

* Go classes

Signed-off-by: Štěpán Tomsa <[email protected]>

* Start the Glob File test

Signed-off-by: Štěpán Tomsa <[email protected]>

* Make tests saner

Signed-off-by: Štěpán Tomsa <[email protected]>

* Fix SOSCleaner for glob files

Signed-off-by: Štěpán Tomsa <[email protected]>

* Revert an unnecessary whitespace change

Signed-off-by: Štěpán Tomsa <[email protected]>

* Remove an unused import

This fixes flake8 violations.

Signed-off-by: Štěpán Tomsa <[email protected]>
(cherry picked from commit a3f6770)
@Glutexo Glutexo deleted the soscleaner-fix branch September 25, 2022 14:29
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* Move results object to ReportItem

Signed-off-by: Štěpán Tomsa <[email protected]>

* Go classes

Signed-off-by: Štěpán Tomsa <[email protected]>

* Start the Glob File test

Signed-off-by: Štěpán Tomsa <[email protected]>

* Make tests saner

Signed-off-by: Štěpán Tomsa <[email protected]>

* Fix SOSCleaner for glob files

Signed-off-by: Štěpán Tomsa <[email protected]>

* Revert an unnecessary whitespace change

Signed-off-by: Štěpán Tomsa <[email protected]>

* Remove an unused import

This fixes flake8 violations.

Signed-off-by: Štěpán Tomsa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client These issues represent work to be done by the "client" team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants