Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: New grub2_editenv_list parser #3481

Merged
merged 13 commits into from
Aug 18, 2022
Merged

Feat: New grub2_editenv_list parser #3481

merged 13 commits into from
Aug 18, 2022

Conversation

TZ3070
Copy link
Contributor

@TZ3070 TZ3070 commented Jul 25, 2022

Signed-off-by: Xinting Li [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

New parser for command 'grub2-editenv list'

@xiangce
Copy link
Contributor

xiangce commented Jul 26, 2022

@TZ3070 - Is this ready for review?

For new spec, please raise an MR/issue to the assets repo first to get it approved at first. Thanks.

Xinting Li added 6 commits July 26, 2022 13:57
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
Xinting Li added 2 commits July 27, 2022 10:42
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
insights/parsers/grubenv.py Outdated Show resolved Hide resolved
insights/parsers/grubenv.py Outdated Show resolved Hide resolved
Signed-off-by: Xinting Li <[email protected]>
insights/parsers/grubenv.py Outdated Show resolved Hide resolved
insights/parsers/grubenv.py Outdated Show resolved Hide resolved
insights/parsers/grubenv.py Outdated Show resolved Hide resolved
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the approval of spec

@xiangce
Copy link
Contributor

xiangce commented Aug 4, 2022

@TZ3070 - since the existing GrubEnv and the new one is a bit relevant, would you please make a combiner for them based on the current implementation?

…ditenv list`` command output

Signed-off-by: Xinting Li <[email protected]>
insights/parsers/grubenv.py Outdated Show resolved Hide resolved
insights/specs/insights_archive.py Outdated Show resolved Hide resolved
insights/tests/parsers/test_grubenv.py Outdated Show resolved Hide resolved
insights/parsers/grubenv.py Outdated Show resolved Hide resolved
insights/parsers/grubenv.py Outdated Show resolved Hide resolved
Xinting Li added 2 commits August 18, 2022 13:44
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
@xiangce xiangce merged commit 618a5e7 into RedHatInsights:master Aug 18, 2022
xiangce pushed a commit that referenced this pull request Aug 18, 2022
* Feat: New grub2_editenv_list parser

Signed-off-by: Xinting Li <[email protected]>

* Update default and init

Signed-off-by: Xinting Li <[email protected]>

* Update __init__

Signed-off-by: Xinting Li <[email protected]>

* Correct docs-test error

Signed-off-by: Xinting Li <[email protected]>

* modify test content name

Signed-off-by: Xinting Li <[email protected]>

* Add doc entry

Signed-off-by: Xinting Li <[email protected]>

* Moving to grubenv

Signed-off-by: Xinting Li <[email protected]>

* Fix flake8 error

Signed-off-by: Xinting Li <[email protected]>

* Add base class

Signed-off-by: Xinting Li <[email protected]>

* modify self._error to self._errors

Signed-off-by: Xinting Li <[email protected]>

* Replace GrubEnv from handle ``/boot/grub2/grubenv`` file to ``grub2-editenv list`` command output

Signed-off-by: Xinting Li <[email protected]>

* Update insights_archive

Signed-off-by: Xinting Li <[email protected]>

* Update doc string

Signed-off-by: Xinting Li <[email protected]>

Signed-off-by: Xinting Li <[email protected]>
Co-authored-by: Xinting Li <[email protected]>
(cherry picked from commit 618a5e7)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* Feat: New grub2_editenv_list parser

Signed-off-by: Xinting Li <[email protected]>

* Update default and init

Signed-off-by: Xinting Li <[email protected]>

* Update __init__

Signed-off-by: Xinting Li <[email protected]>

* Correct docs-test error

Signed-off-by: Xinting Li <[email protected]>

* modify test content name

Signed-off-by: Xinting Li <[email protected]>

* Add doc entry

Signed-off-by: Xinting Li <[email protected]>

* Moving to grubenv

Signed-off-by: Xinting Li <[email protected]>

* Fix flake8 error

Signed-off-by: Xinting Li <[email protected]>

* Add base class

Signed-off-by: Xinting Li <[email protected]>

* modify self._error to self._errors

Signed-off-by: Xinting Li <[email protected]>

* Replace GrubEnv from handle ``/boot/grub2/grubenv`` file to ``grub2-editenv list`` command output

Signed-off-by: Xinting Li <[email protected]>

* Update insights_archive

Signed-off-by: Xinting Li <[email protected]>

* Update doc string

Signed-off-by: Xinting Li <[email protected]>

Signed-off-by: Xinting Li <[email protected]>
Co-authored-by: Xinting Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants