Update the marker for MustGatherContext #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current marker 'namespaces' matches RHCOS SOSReport archives. RHCOS SOS-Report archives are always identified as MustGatherContext instead of SosArchiveContext, thus no rule hits result when running rules against RHCOS SOS-Report. The commit changes the marker of MustGatherContext to 'cluster-scoped-resources' to avoid matching RHCOS SOSReport. Signed-off-by: shzhou <[email protected]>
|
@xiangce Could you please help to review this MR? |
xiangce
approved these changes
Jul 25, 2022
|
@bfahr - I approved it since I think this would be a quick workaround for CCX rules to distinguish the sosreport and the must-gather more clearly before the long-term context resolution, Please have a review too. |
bfahr
approved these changes
Jul 29, 2022
xiangce
pushed a commit
that referenced
this pull request
Aug 1, 2022
The current marker 'namespaces' matches RHCOS SOSReport archives. RHCOS SOS-Report archives are always identified as MustGatherContext instead of SosArchiveContext, thus no rule hits result when running rules against RHCOS SOS-Report. The commit changes the marker of MustGatherContext to 'cluster-scoped-resources' to avoid matching RHCOS SOSReport. Signed-off-by: shzhou <[email protected]> (cherry picked from commit 640a031)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
The current marker 'namespaces' matches RHCOS SOSReport archives. RHCOS SOS-Report archives are always identified as MustGatherContext instead of SosArchiveContext, thus no rule hits result when running rules against RHCOS SOS-Report. The commit changes the marker of MustGatherContext to 'cluster-scoped-resources' to avoid matching RHCOS SOSReport. Signed-off-by: shzhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current marker 'namespaces' matches RHCOS SOSReport archives. RHCOS SOS-Report archives are always identified as MustGatherContext instead of SosArchiveContext, thus no rule hits result when running rules against RHCOS SOS-Report. The commit changes the marker of MustGatherContext to 'cluster-scoped-resources' to avoid matching RHCOS SOSReport.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here