fix: Add spec "lvmconfig" back #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiangce Please help to review, thanks. |
xiangce
requested changes
Jul 21, 2022
There was a problem hiding this comment.
- please open an issue of this change to the core-assets repo, since it's a kind of spec change
- please use conventional commit message, see https://www.conventionalcommits.org/en/v1.0.0/
|
Oops, my mistake, These two specs are already added to the uploader.json. No Spec Change to uploader.json is required. |
* the spec is used in rules, so add it back Signed-off-by: Huanhuan Li <[email protected]>
huali027
changed the title
xiangce
approved these changes
Jul 21, 2022
psachin
approved these changes
Jul 21, 2022
psachin
pushed a commit
that referenced
this pull request
Jul 21, 2022
* the spec is used in rules, so add it back Signed-off-by: Huanhuan Li <[email protected]> (cherry picked from commit d301c74)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* the spec is used in rules, so add it back Signed-off-by: Huanhuan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Huanhuan Li [email protected]
All Pull Requests:
Check all that apply:
Add your description here
The parser "LvmConf" is replaced by parser "LvmConfig" in rules, so add the spec back.