Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: test error of nmcli command in the datasource ethernet #3468

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix: test error of nmcli command in the datasource ethernet #3468

merged 1 commit into from
Jul 14, 2022

Conversation

TZ3070
Copy link
Contributor

@TZ3070 TZ3070 commented Jul 14, 2022

Signed-off-by: Xinting Li [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

  • Fixed an incorrect test case newly added to the ethernet datasource.

Signed-off-by: Xinting Li <[email protected]>
@TZ3070 TZ3070 changed the title Fix: test error Fix: ethernet test error Jul 14, 2022
@xiangce xiangce changed the title Fix: ethernet test error Fix: test error of nmcli command in the datasource ethernet Jul 14, 2022
@xiangce
Copy link
Contributor

xiangce commented Jul 14, 2022

The test of py26 is hung due to the environment issue again. I will ignore it and merge the PR directly.

@xiangce xiangce merged commit ed63a18 into RedHatInsights:master Jul 14, 2022
xiangce pushed a commit that referenced this pull request Jul 14, 2022
Signed-off-by: Xinting Li <[email protected]>

Co-authored-by: Xinting Li <[email protected]>
(cherry picked from commit ed63a18)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants