Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unregister option removes machine-id #3449

Merged
merged 2 commits into from
Jul 14, 2022
Merged

feat: Unregister option removes machine-id #3449

merged 2 commits into from
Jul 14, 2022

Conversation

ahitacat
Copy link
Contributor

@ahitacat ahitacat commented Jun 22, 2022

Resolves: rhbz#1919570

Signed-off-by: ahitacat [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

This new feature modifies the unregistration process and deletes that machine-id file. It also adds a new test to check unregistering.

This feature is aligned with RHIN-500 and resolves rhbz#1919570

@ahitacat ahitacat added the client These issues represent work to be done by the "client" team. label Jun 22, 2022
@ahitacat ahitacat requested review from subpop, strider and Glutexo June 22, 2022 11:17
@ahitacat ahitacat self-assigned this Jun 22, 2022
Resolves: rhbz#1919570

Signed-off-by: ahitacat <[email protected]>
Copy link
Contributor

@strider strider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, jenkins-qe jobs are failing on 6.10 and 7.9 with an IQE issue (not PR related).

ImportError: cannot import name 'assume' from 'hypothesis' (/iqe_venv/lib64/python3.8/site-packages/hypothesis/__init__.py)

@xiangce xiangce merged commit 44c19db into RedHatInsights:master Jul 14, 2022
xiangce pushed a commit that referenced this pull request Jul 14, 2022
Resolves: rhbz#1919570

Signed-off-by: ahitacat <[email protected]>

Co-authored-by: Glutexo <[email protected]>
(cherry picked from commit 44c19db)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Resolves: rhbz#1919570

Signed-off-by: ahitacat <[email protected]>

Co-authored-by: Glutexo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client These issues represent work to be done by the "client" team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants