feat: add "modinfo_filtered_modules" to collect the filtered modules information #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiangce Please help to review, thanks. |
huali027
changed the title
huali027
changed the title
…ltered modules * Update spec "modinfo" to filterable * Deprecate all other modinfo specs Signed-off-by: Huanhuan Li <[email protected]>
|
@xiangce Please help to review, thanks. |
xiangce
requested changes
Jun 27, 2022
insights/specs/__init__.py
Outdated
| @@ -387,7 +387,7 @@ class Specs(SpecSet): | |||
| modinfo_ixgbe = RegistryPoint() | |||
| modinfo_veth = RegistryPoint() | |||
| modinfo_vmxnet3 = RegistryPoint() | |||
| modinfo = RegistryPoint(multi_output=True) | |||
| modinfo = RegistryPoint(filterable=True) | |||
There was a problem hiding this comment.
Since removing the multi_output=True will change the usage of the Parser, better to use another symbolink name.
insights/parsers/modinfo.py
Outdated
| ----------------------------------------------- | ||
| for all modules listed by ``lsmod`` | ||
|
|
||
| ModInfoAll - Command ``modinfo *(filtered modules)`` |
There was a problem hiding this comment.
Since there is a All in the name ModInfoAll, it makes me think this is the parser for all the modules loaded on this host. How about using another name? like ModuleInfo
There was a problem hiding this comment.
@xiangce, good to me, I'll update it.
|
@huali027 - please add a short description to the MR in the first comment. |
huali027
changed the title
* Add new spec "modinfo_modules" to collect the filtered modules * Add another new spec "modinfo_filtered_modules" to run "modinfo filtered_modules" since the result will be filtered if the spec is filterable, and then other info without the filter words will be ignored, which is not expected. Signed-off-by: Huanhuan Li <[email protected]>
|
@xiangce updated based on the comments, please help to review. |
Signed-off-by: Huanhuan Li <[email protected]>
psachin
approved these changes
Jun 30, 2022
xiangce
pushed a commit
that referenced
this pull request
Jun 30, 2022
…information (#3447) * feat: add "modinfo_all" back and enhance it to get modinfo for all filtered modules * Update spec "modinfo" to filterable * Deprecate all other modinfo specs Signed-off-by: Huanhuan Li <[email protected]> * feat: Add new specs instead of updating original spec directly * Add new spec "modinfo_modules" to collect the filtered modules * Add another new spec "modinfo_filtered_modules" to run "modinfo filtered_modules" since the result will be filtered if the spec is filterable, and then other info without the filter words will be ignored, which is not expected. Signed-off-by: Huanhuan Li <[email protected]> * fixes: Fix failed test Signed-off-by: Huanhuan Li <[email protected]> (cherry picked from commit b134ec5)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
…information (#3447) * feat: add "modinfo_all" back and enhance it to get modinfo for all filtered modules * Update spec "modinfo" to filterable * Deprecate all other modinfo specs Signed-off-by: Huanhuan Li <[email protected]> * feat: Add new specs instead of updating original spec directly * Add new spec "modinfo_modules" to collect the filtered modules * Add another new spec "modinfo_filtered_modules" to run "modinfo filtered_modules" since the result will be filtered if the spec is filterable, and then other info without the filter words will be ignored, which is not expected. Signed-off-by: Huanhuan Li <[email protected]> * fixes: Fix failed test Signed-off-by: Huanhuan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Huanhuan Li [email protected]
All Pull Requests:
Check all that apply: