Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests that removing temp archives #3445

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Fix tests that removing temp archives #3445

merged 1 commit into from
Jun 17, 2022

Conversation

ahitacat
Copy link
Contributor

Signed-off-by: ahitacat [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Test were passing but it ended throwing these errors:

ERROR:insights.client.archive:ERROR: Could not create /var/cache/insights-client
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/home/bfahr/work/insights/insights-core/insights/client/archive.py", line 261, in storing_archive
    os.makedirs(self.keep_archive_dir)
  File "/usr/lib64/python3.8/os.py", line 223, in makedirs
    mkdir(name, mode)
PermissionError: [Errno 13] Permission denied: '/var/cache/insights-client'

This PR mocked atexit call that was causing this error.

@ahitacat ahitacat added the bug label Jun 17, 2022
@subpop subpop added client These issues represent work to be done by the "client" team. app Apps embedded in the Insights Core labels Jun 17, 2022
subpop
subpop approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@subpop subpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all test changes. +1

@subpop subpop merged commit 2ded224 into RedHatInsights:master Jun 17, 2022
subpop pushed a commit that referenced this pull request Jun 17, 2022
@ahitacat @subpop
Fix tests that removing temp archives (#3445)
514b99e 
Signed-off-by: ahitacat <[email protected]>
xiangce pushed a commit that referenced this pull request Sep 6, 2024
@ahitacat
Fix tests that removing temp archives (#3445)
0878bbe 
Signed-off-by: ahitacat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subpop subpop subpop approved these changes

@strider strider Awaiting requested review from strider

@Glutexo Glutexo Awaiting requested review from Glutexo

@mhuth mhuth Awaiting requested review from mhuth

@bfahr bfahr Awaiting requested review from bfahr

Assignees
No one assigned
Labels
app Apps embedded in the Insights Core bug client These issues represent work to be done by the "client" team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahitacat @subpop