feat: Support parallelly running for insights-engine #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-blakley
approved these changes
Jun 7, 2022
xiangce
added a commit
that referenced
this pull request
Jun 8, 2022
Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit bbabfae)
xiangce
added a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiangce Liu [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
The insights-engine (old) runs rules via the InsightsEvaluators, this PR updates the Evaluators to support running rules in parallel.
parallelas an attribute of theEvaluatorsclass, since I think it is better to pass it via arguments. (The same to theincremental, but to avoid breaking the interface, I didn't touch it in this change)