Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content_type [rhbz#2083665] #3435

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Fix content_type [rhbz#2083665] #3435

merged 1 commit into from
Jun 15, 2022

Conversation

ahitacat
Copy link
Contributor

@ahitacat ahitacat commented Jun 6, 2022

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

According to documentation, content-type can be: gz, bz2, xz or none and should match the compression type of the payload. But using content-type this way is causing an error while uploading the archive, as it needs a MIME content-type structure.

This fix appends the compression type to the content-type required to upload an archive application/vnd.redhat.com.advisor.collection+. Also ensures that the compression of the archive is the same as the content-type provide.

Resolves: rhbz#2083665

@ahitacat ahitacat added the client These issues represent work to be done by the "client" team. label Jun 6, 2022
@ahitacat ahitacat requested review from subpop, strider and Glutexo June 6, 2022 15:32
@ahitacat
Copy link
Contributor Author

@skateman @mhuth This fix modifies content-type that both malware and compliance uses. Although, in principle, the use for both applications should not be affected I would like to avoid possible regression errors. Could you check this PR?

@ahitacat ahitacat requested a review from mhuth June 14, 2022 10:20
@ahitacat
Append compression type to content-type of MIME. Compare file compres…
1c90a63 
…sion with content_type.

Resolves: rhbz#2083665
Signed-off-by: ahitacat <[email protected]>
@LightOfHeaven1994
Copy link
Contributor

@ahitacat checked Compliance with this MR, works fine. Thanks

skateman
skateman approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

strider
strider approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@strider strider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@subpop subpop merged commit 2b56f22 into RedHatInsights:master Jun 15, 2022
subpop pushed a commit that referenced this pull request Jun 15, 2022
@ahitacat @subpop
Append compression type to content-type of MIME. Compare file compres…
da5d45f 
…sion with content_type. (#3435)

Resolves: rhbz#2083665
Signed-off-by: ahitacat <[email protected]>
xiangce pushed a commit that referenced this pull request Sep 6, 2024
@ahitacat
Append compression type to content-type of MIME. Compare file compres…
9bc5b49 
…sion with content_type. (#3435)

Resolves: rhbz#2083665
Signed-off-by: ahitacat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

@strider strider strider approved these changes

@subpop subpop Awaiting requested review from subpop

@Glutexo Glutexo Awaiting requested review from Glutexo

@mhuth mhuth Awaiting requested review from mhuth

Assignees

@strider strider

Labels
client These issues represent work to be done by the "client" team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahitacat @LightOfHeaven1994 @strider @skateman @subpop