Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --no-load-default arg to the insights-run command #3434

Merged
merged 0 commits into from
Jun 9, 2022
Merged

feat: Add --no-load-default arg to the insights-run command #3434

merged 0 commits into from
Jun 9, 2022

Conversation

ryan-blakley
Copy link
Contributor

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add --no-load-default arg, if this arg is passed the default plugins aren't loaded. This allows the execution of other projects without loading all the specs from core which can cause exceptions. Re-ordered the arguments so that they're in alphabetical order. Added some empty lines between some of the code below the args so that it's easier to read.

Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@xiangce xiangce merged commit 97fbefd into RedHatInsights:master Jun 9, 2022
psachin pushed a commit that referenced this pull request Jun 9, 2022
* Add --no-load-default arg, if this arg is passed the default plugins
  aren't loaded. This allows the execution of other projects without
  loading all the specs from core which can cause exceptions.
* Re-ordered the arguments so that they're in alphabetical order.
* Added some empty lines between some of the code below the args so that
  it's easier to read.

Signed-off-by: Ryan Blakley <[email protected]>
(cherry picked from commit 97fbefd)
@ryan-blakley ryan-blakley deleted the add_no_load_default_arg branch October 18, 2022 18:45
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* Add --no-load-default arg, if this arg is passed the default plugins
  aren't loaded. This allows the execution of other projects without
  loading all the specs from core which can cause exceptions.
* Re-ordered the arguments so that they're in alphabetical order.
* Added some empty lines between some of the code below the args so that
  it's easier to read.

Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants