Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating sos_archive to parse file for GSS rule #3432

Merged
merged 0 commits into from
Jun 2, 2022
Merged

Updating sos_archive to parse file for GSS rule #3432

merged 0 commits into from
Jun 2, 2022

Conversation

mohitkumarrh
Copy link
Contributor

@mohitkumarrh mohitkumarrh commented Jun 1, 2022 •
edited by xiangce
Loading

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

adding systemd_analyze_blame = simple_file("insights_commands/systemd-analyze_blame") in insights_archive.py

xiangce
xiangce requested changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohitkumarrh - please fix the DCO check error

  • DCO Details
    And it should be sos_archives.py in the description section, Right?

@psachin
Copy link
Contributor

psachin commented Jun 2, 2022

@mohitkumarrh - please fix the DCO check error

* [DCO Details](https://github.com/RedHatInsights/insights-core/pull/3432/checks?check_run_id=6684602034)
  And it should be `sos_archives.py` in the description section, Right?

@xiangce As this is specific to the GSS, we better move this to the internal repo shared_rules/specs/sos_archive.py

@xiangce
Copy link
Contributor

xiangce commented Jun 2, 2022 •
edited
Loading

@mohitkumarrh - please fix the DCO check error

* [DCO Details](https://github.com/RedHatInsights/insights-core/pull/3432/checks?check_run_id=6684602034)
  And it should be `sos_archives.py` in the description section, Right?

@xiangce As this is specific to the GSS, we better move this to the internal repo shared_rules/specs/sos_archive.py

Nope, the case only occurs when the spec is for GSS rules only.

As this spec was once added for an advisor rule, the parser is already implemented in the core. It's Okay to enable it for sos_archvies in case the existing advisor rule would also be triggered against the sosreport.

@xiangce
Copy link
Contributor

xiangce commented Jun 2, 2022

The CI failed due to environmental issues, I ignored the failed tests and merged this PR directly.

@xiangce xiangce merged commit 1149b01 into RedHatInsights:master Jun 2, 2022
xiangce pushed a commit that referenced this pull request Jun 2, 2022
@mohitkumarrh @xiangce
Updating sos_archive to parse file for GSS rule (#3432)
e866b2d 
adding systemd_analyze_blame = simple_file("insights_commands/systemd-analyze_blame")  in sos_archive.py

Signed-off-by: Mohit Kumar <[email protected]>
(cherry picked from commit 1149b01)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
@mohitkumarrh
Updating sos_archive to parse file for GSS rule (#3432)
8b41e0a 
adding systemd_analyze_blame = simple_file("insights_commands/systemd-analyze_blame")  in sos_archive.py

Signed-off-by: Mohit Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangce xiangce xiangce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohitkumarrh @psachin @xiangce