feat: new spec and parser for /etc/sudoers #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psachin
reviewed
Jun 1, 2022
| from insights.parsers.sudoers import EtcSudoers | ||
|
|
||
|
|
||
| @combiner(EtcSudoers) |
There was a problem hiding this comment.
@xiangce Generally we develop combiner out of two or more components. Is there are special requirement because of which you decide to create a combiner out of EtcSudoers parser alone?
There was a problem hiding this comment.
Besides the code of get() & last() in the combiner as well as the parser is redundant.
There was a problem hiding this comment.
The EtcSudoers is against a multi_output=Ture spec, which results in the parser result being a list. This combiner is going to combine the result.
For the 2 functions, I created a base class and removed the duplicates. Please have a look again.
psachin
approved these changes
Jun 2, 2022
xiangce
added a commit
that referenced
this pull request
Jun 2, 2022
* New spec and parser for /etc/sudoers Signed-off-by: Xiangce Liu <[email protected]> * feat: New spec and parser for /etc/sudoers Signed-off-by: Xiangce Liu <[email protected]> * fix combiner to check the '#includedir' directive Signed-off-by: Xiangce Liu <[email protected]> * single test func Signed-off-by: Xiangce Liu <[email protected]> * add note for #inlcudedir Signed-off-by: Xiangce Liu <[email protected]> * add the missed multi_output=True Signed-off-by: Xiangce Liu <[email protected]> * add a base class Signed-off-by: Xiangce Liu <[email protected]> * add note to the combiner for the base class Signed-off-by: Xiangce Liu <[email protected]> * refine the doc Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit b90b141)
xiangce
added a commit
that referenced
this pull request
Sep 6, 2024
* New spec and parser for /etc/sudoers Signed-off-by: Xiangce Liu <[email protected]> * feat: New spec and parser for /etc/sudoers Signed-off-by: Xiangce Liu <[email protected]> * fix combiner to check the '#includedir' directive Signed-off-by: Xiangce Liu <[email protected]> * single test func Signed-off-by: Xiangce Liu <[email protected]> * add note for #inlcudedir Signed-off-by: Xiangce Liu <[email protected]> * add the missed multi_output=True Signed-off-by: Xiangce Liu <[email protected]> * add a base class Signed-off-by: Xiangce Liu <[email protected]> * add note to the combiner for the base class Signed-off-by: Xiangce Liu <[email protected]> * refine the doc Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here