feat: New spec and parser for group_info #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
force-pushed
the
sap_sudo
branch
3 times, most recently
from
5d3eb97 to
0f15dd6
Compare
bfahr
requested changes
May 31, 2022
|
|
||
|
|
||
| @datasource(HostContext) | ||
| def groups(broker): |
There was a problem hiding this comment.
@xiangce this confused me at first. Your not really collecting anything here, but just returning the list of filters for this data spec. What do you think about renaming it to something like group_filters instead of groups? Its an unexpected way of using filters, but I believe it provides the same net results.
There was a problem hiding this comment.
@bfahr - Updated. Thanks for the suggestion.
There was a problem hiding this comment.
@xiangce that looks good, thanks!
psachin
reviewed
Jun 1, 2022
psachin
approved these changes
Jun 2, 2022
xiangce
added a commit
that referenced
this pull request
Jun 2, 2022
* feat: New spec and parser for group_info Signed-off-by: Xiangce Liu <[email protected]> * Add test for datasource 'groups' Signed-off-by: Xiangce Liu <[email protected]> * Add doc entry for groups Signed-off-by: Xiangce Liu <[email protected]> * add doc entry for user_group parser Signed-off-by: Xiangce Liu <[email protected]> * fix examples in doc Signed-off-by: Xiangce Liu <[email protected]> * fix the test of datasource Signed-off-by: Xiangce Liu <[email protected]> * fix the test of datasource - 2 Signed-off-by: Xiangce Liu <[email protected]> * add NOTE for sensitive information Signed-off-by: Xiangce Liu <[email protected]> * add note for filter of groupname Signed-off-by: Xiangce Liu <[email protected]> * change func name Signed-off-by: Xiangce Liu <[email protected]> * Rename the datasource to 'group_filter_list' Signed-off-by: Xiangce Liu <[email protected]> * revert back to return a string Signed-off-by: Xiangce Liu <[email protected]> * rename users Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit 598e88d)
xiangce
added a commit
that referenced
this pull request
Sep 6, 2024
* feat: New spec and parser for group_info Signed-off-by: Xiangce Liu <[email protected]> * Add test for datasource 'groups' Signed-off-by: Xiangce Liu <[email protected]> * Add doc entry for groups Signed-off-by: Xiangce Liu <[email protected]> * add doc entry for user_group parser Signed-off-by: Xiangce Liu <[email protected]> * fix examples in doc Signed-off-by: Xiangce Liu <[email protected]> * fix the test of datasource Signed-off-by: Xiangce Liu <[email protected]> * fix the test of datasource - 2 Signed-off-by: Xiangce Liu <[email protected]> * add NOTE for sensitive information Signed-off-by: Xiangce Liu <[email protected]> * add note for filter of groupname Signed-off-by: Xiangce Liu <[email protected]> * change func name Signed-off-by: Xiangce Liu <[email protected]> * Rename the datasource to 'group_filter_list' Signed-off-by: Xiangce Liu <[email protected]> * revert back to return a string Signed-off-by: Xiangce Liu <[email protected]> * rename users Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiangce Liu [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
New datasource spec and parser for group info