Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: exception with "Reading VG shared_vg1 without a lock" #3412

Merged
merged 2 commits into from
May 19, 2022
+16 −0
Merged

fixes: exception with "Reading VG shared_vg1 without a lock" #3412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c554f27
fixes: exception with "Reading VG shared_vg1 without a lock"
huali027 May 17, 2022
89b03b5
Add test for the parser "Vgs" with extra tips
huali027 May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions insights/parsers/lvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ def find_warnings(content):
"Attempt to close device",
"Ignoring supplied major",
"not match metadata",
"Reading VG"
]
]
for l in content:
Expand Down
15 changes: 15 additions & 0 deletions insights/tests/parsers/test_lvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@
Configuration setting "activation/thin_check_options" unknown.
""".strip()

CONTENT_WITH_EXTRA_LOCK_TIPS = """
WARNING: locking_type (0) is deprecated, using --nolocking.
WARNING: File locking is disabled.
Reading VG shared_vg1 without a lock.
LVM2_VG_FMT='lvm2'|LVM2_VG_UUID='V1AMDw-e9x6-AdCq-p3Hr-6cYn-otra-ducLAc'|LVM2_VG_NAME='rhel'|LVM2_VG_ATTR='wz--n-'|LVM2_VG_PERMISSIONS='writeable'|LVM2_VG_EXTENDABLE='extendable'|LVM2_VG_EXPORTED=''|LVM2_VG_AUTOACTIVATION='enabled'|LVM2_VG_PARTIAL=''|LVM2_VG_ALLOCATION_POLICY='normal'|LVM2_VG_CLUSTERED=''|LVM2_VG_SHARED=''|LVM2_VG_SIZE='<29.00g'|LVM2_VG_FREE='0 '|LVM2_VG_SYSID=''|LVM2_VG_SYSTEMID=''|LVM2_VG_LOCK_TYPE=''|LVM2_VG_LOCK_ARGS=''|LVM2_VG_EXTENT_SIZE='4.00m'|LVM2_VG_EXTENT_COUNT='7423'|LVM2_VG_FREE_COUNT='0'|LVM2_MAX_LV='0'|LVM2_MAX_PV='0'|LVM2_PV_COUNT='1'|LVM2_VG_MISSING_PV_COUNT='0'|LVM2_LV_COUNT='2'|LVM2_SNAP_COUNT='0'|LVM2_VG_SEQNO='3'|LVM2_VG_TAGS=''|LVM2_VG_PROFILE=''|LVM2_VG_MDA_COUNT='1'|LVM2_VG_MDA_USED_COUNT='1'|LVM2_VG_MDA_FREE='507.50k'|LVM2_VG_MDA_SIZE='1020.00k'|LVM2_VG_MDA_COPIES='unmanaged'
"""


def test_find_warnings():
data = [l for l in lvm.find_warnings(WARNINGS_CONTENT.splitlines())]
Expand Down Expand Up @@ -79,3 +86,11 @@ def test_vgsheading_warnings():
assert len(result.warnings) == 6
assert 'Configuration setting "activation/thin_check_executable" unknown.' in result.warnings
assert 'WARNING: Locking disabled. Be careful! This could corrupt your metadata.' in result.warnings


def test_vgs_with_extra_tips():
result = lvm.Vgs(context_wrap(CONTENT_WITH_EXTRA_LOCK_TIPS))
assert result is not None
assert len(result.data.get('warnings')) == 3
assert 'Reading VG shared_vg1 without a lock.' in result.data.get('warnings')
assert len(result.data.get('content')) == 1