Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add spec and parser for 'containers_policy' #3394

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Feat: Add spec and parser for 'containers_policy' #3394

merged 2 commits into from
Apr 28, 2022

Conversation

shlao
Copy link
Contributor

@shlao shlao commented Apr 22, 2022

Signed-off-by: shlao [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

CRI-O crashes with "_gpgme_ath_mutex_lock" on worker nodes when signature verification is enabled. The signature verification policy, /etc/containers/policy.json, specifies the policy. For the Detail info, please see: INSIGHTOCP-695 card.

@shlao
Copy link
Contributor Author

shlao commented Apr 22, 2022

@xiangce Will you help me review the MR? Thanks!

@shlao shlao requested a review from xiangce April 22, 2022 04:28
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No Spec approval is needed, since this parser targets on sosreport only.

@xiangce xiangce merged commit 6c47311 into RedHatInsights:master Apr 28, 2022
xiangce pushed a commit that referenced this pull request Apr 28, 2022
* Feat: Add spec and parser for 'containers_policy'

Signed-off-by: shlao <[email protected]>

* Updated the class docstring

Signed-off-by: shlao <[email protected]>
(cherry picked from commit 6c47311)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* Feat: Add spec and parser for 'containers_policy'

Signed-off-by: shlao <[email protected]>

* Updated the class docstring

Signed-off-by: shlao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants