fix: Multiline quote parsing of httpd conf files #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The parsr logic didn't handle line continuations properly, and didn't handle multiline quoted directives either. I fixed the logic and added in tests. Signed-off-by: Ryan Blakley <[email protected]>
bfahr
approved these changes
Apr 20, 2022
|
Looks good to me |
vdymna
approved these changes
Apr 20, 2022
bfahr
pushed a commit
that referenced
this pull request
Apr 20, 2022
* The parsr logic didn't handle line continuations properly, and didn't handle multiline quoted directives either. I fixed the logic and added in tests. Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit 2864da3)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* The parsr logic didn't handle line continuations properly, and didn't handle multiline quoted directives either. I fixed the logic and added in tests. Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply:
Complete Description of Additions/Changes:
The parsr logic didn't handle line continuations properly, and didn't handle multi-line quoted directives either. I fixed the logic and added in tests.