fix: make sure JSONParser is compatible with RawFileProvider #3390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
changed the title
- since the spec `tags` is from RawFileProvider Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
xiangce
changed the title
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
bfahr
approved these changes
Apr 19, 2022
xiangce
added a commit
that referenced
this pull request
Apr 20, 2022
* fix: make sure JSONParser is compatible with RawFileProvider - since the spec `tags` is from RawFileProvider Signed-off-by: Xiangce Liu <[email protected]> * add tests in which content is in bytes Signed-off-by: Xiangce Liu <[email protected]> * revert the update to Specs.tags Signed-off-by: Xiangce Liu <[email protected]> * fix the test error of python2 Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit 5a207ad)
xiangce
added a commit
that referenced
this pull request
Sep 6, 2024
* fix: make sure JSONParser is compatible with RawFileProvider - since the spec `tags` is from RawFileProvider Signed-off-by: Xiangce Liu <[email protected]> * add tests in which content is in bytes Signed-off-by: Xiangce Liu <[email protected]> * revert the update to Specs.tags Signed-off-by: Xiangce Liu <[email protected]> * fix the test error of python2 Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagsis from RawFileProviderSigned-off-by: Xiangce Liu [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
The spec
tagsis set as a RawFileProvider kind, but theJSONParsertakes the content as a list fromTextFileProviderby default. This PR makes the JSONParser to work with both of them.