fix: Update the spec "du_dirs" to filterable #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huanhuan Li <[email protected]>
|
@xiangce, please help to review, thanks. |
xiangce
requested changes
Apr 13, 2022
Signed-off-by: Huanhuan Li <[email protected]>
xiangce
reviewed
Apr 14, 2022
* Also raise SkipComponent if there are no filters Signed-off-by: Huanhuan Li <[email protected]>
xiangce
approved these changes
Apr 18, 2022
xiangce
pushed a commit
that referenced
this pull request
Apr 18, 2022
* fix: Update the spec "du_dirs" to filterable Signed-off-by: Huanhuan Li <[email protected]> * Move the "du_dirs_list" datasource to the datasource directory Signed-off-by: Huanhuan Li <[email protected]> * Rename to "dir_list" * Also raise SkipComponent if there are no filters Signed-off-by: Huanhuan Li <[email protected]> (cherry picked from commit 7d78fc5)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix: Update the spec "du_dirs" to filterable Signed-off-by: Huanhuan Li <[email protected]> * Move the "du_dirs_list" datasource to the datasource directory Signed-off-by: Huanhuan Li <[email protected]> * Rename to "dir_list" * Also raise SkipComponent if there are no filters Signed-off-by: Huanhuan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Huanhuan Li [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
fixes: #3383