fix: strip the '\x00' from the ibm_fw_vernum_encoded before parsing #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
enhance_IBMFirmwareLevel
branch
from
d102bc9 to
10624c8
Compare
Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
enhance_IBMFirmwareLevel
branch
from
10624c8 to
3719aff
Compare
Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
enhance_IBMFirmwareLevel
branch
from
80591bc to
38edd49
Compare
|
@xiangce Can you include the test case to cover the exception? |
Signed-off-by: Xiangce Liu <[email protected]>
psachin
approved these changes
Apr 19, 2022
lhuett
pushed a commit
that referenced
this pull request
Apr 19, 2022
…3378) * fix: strip the '\x00' from the ibm_fw_vernum_encoded before parsing Signed-off-by: Xiangce Liu <[email protected]> * use instead of Signed-off-by: Xiangce Liu <[email protected]> * fix typo Signed-off-by: Xiangce Liu <[email protected]> * add test Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit e68bcd9)
xiangce
added a commit
that referenced
this pull request
Sep 6, 2024
…3378) * fix: strip the '\x00' from the ibm_fw_vernum_encoded before parsing Signed-off-by: Xiangce Liu <[email protected]> * use instead of Signed-off-by: Xiangce Liu <[email protected]> * fix typo Signed-off-by: Xiangce Liu <[email protected]> * add test Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiangce Liu [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
According to the collected
ibm_fw_vernum_encodedfile, there is a\x00invisible symbol at the EOL. This PR removed this invisible symbol.