Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly obfuscate IP addresses at EOL #3376

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

subpop
Copy link
Collaborator

@subpop subpop commented Apr 5, 2022

Account for cases where IP addresses can appear at the end of a line in
the space-preserving netstat obfuscation function _sub_ip_netstat.

Resolves: RHBZ#2029997
Signed-off-by: Link Dupont [email protected]

Account for cases where IP addresses can appear at the end of a line in
the space-preserving netstat obfuscation function _sub_ip_netstat.

Resolves: RHBZ#2029997
Signed-off-by: Link Dupont <[email protected]>
@subpop subpop added the client These issues represent work to be done by the "client" team. label Apr 5, 2022
@subpop subpop requested review from ahitacat, Glutexo and strider April 5, 2022 17:00
Copy link
Contributor

@ahitacat ahitacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well per the tests

@xiangce xiangce merged commit bef145c into master Apr 7, 2022
@xiangce xiangce deleted the fix-2029997-ip-netstat-eol branch April 7, 2022 05:54
xiangce pushed a commit that referenced this pull request Apr 7, 2022
Account for cases where IP addresses can appear at the end of a line in
the space-preserving netstat obfuscation function _sub_ip_netstat.

Resolves: RHBZ#2029997
Signed-off-by: Link Dupont <[email protected]>
(cherry picked from commit bef145c)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Account for cases where IP addresses can appear at the end of a line in
the space-preserving netstat obfuscation function _sub_ip_netstat.

Resolves: RHBZ#2029997
Signed-off-by: Link Dupont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client These issues represent work to be done by the "client" team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants