-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Traceback" of datasources is a string but not list #3578
Comments
This was referenced Nov 2, 2022
xiangce
added a commit
that referenced
this issue
Nov 8, 2022
* fix: values of broker.tracebacks should be string - fix: #3578 Signed-off-by: Xiangce Liu <[email protected]> * one more test item Signed-off-by: Xiangce Liu <[email protected]> * test tracebacks in meta_data file * move the test to test_serde * mini update Signed-off-by: Xiangce Liu <[email protected]>
xiangce
added a commit
that referenced
this issue
Nov 8, 2022
* fix: values of broker.tracebacks should be string - fix: #3578 Signed-off-by: Xiangce Liu <[email protected]> * one more test item Signed-off-by: Xiangce Liu <[email protected]> * test tracebacks in meta_data file * move the test to test_serde * mini update Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit e713e3f)
xiangce
added a commit
that referenced
this issue
Sep 6, 2024
* fix: values of broker.tracebacks should be string - fix: #3578 Signed-off-by: Xiangce Liu <[email protected]> * one more test item Signed-off-by: Xiangce Liu <[email protected]> * test tracebacks in meta_data file * move the test to test_serde * mini update Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When storing the Tracebacks of datasources to the
meta_data
, the result looks like:It treated the "broker.tracebacks[key]" as a list by mistake,
insights-core/insights/core/serde.py
Lines 201 to 204 in 4bd939d
but in fact, it's a string:
insights-core/insights/core/dr.py
Lines 858 to 863 in 4bd939d
e.g.:
insights-core/insights/core/dr.py
Lines 1041 to 1043 in 4bd939d
The text was updated successfully, but these errors were encountered: