New version of flake8 found some errors (#3488)

* Version 5.0.2 of flake8 detected some errors that needed to be fixed to allow CI/CD tests to pass Signed-off-by: Bob Fahr <[email protected]> (cherry picked from commit 4e6611a)
RedHatInsights · Aug 1, 2022 · 8318b60 · 8318b60
1 parent 99d0b62
commit 8318b60
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/insights/client/utilities.py b/insights/client/utilities.py
@@ -473,7 +473,7 @@ def largest_spec_in_archive(archive_file):
                 abs_fname = os.path.join('.', data_top, fname)
                 # get the archives from inside data directory
                 data_file = tar_file.getmember(abs_fname)
-                if(data_file.size > largest_fsize):
+                if (data_file.size > largest_fsize):
                     largest_fsize = data_file.size
                     largest_file_name = fname
                     largest_spec = specs_metadata["name"]

diff --git a/insights/parsers/__init__.py b/insights/parsers/__init__.py
@@ -284,7 +284,7 @@ def calc_offset(lines, target, invert_search=False, require_all=False):
                         return offset
                 else:
                     return offset
-            elif invert_search and not(line == '' or found_any):
+            elif invert_search and not (line == '' or found_any):
                 return offset
 
         # If we get here then we didn't find any of the targets

diff --git a/insights/parsers/passenger_status.py b/insights/parsers/passenger_status.py
@@ -84,7 +84,7 @@ def parse_content(self, content):
                         group_list['p_list'].append(p_dict)
                     l = line.lstrip('* ')
                     # parse each key: value pair
-                    while(':' in l and l.index(':') != l.rindex(':')):
+                    while (':' in l and l.index(':') != l.rindex(':')):
                         k, l = [i.strip() for i in l.split(':', 1)]
                         v, l = [i.strip() for i in l.split(None, 1)]
                         p_dict[k] = v

diff --git a/insights/parsers/sealert.py b/insights/parsers/sealert.py
@@ -29,7 +29,7 @@ def lines_stripped(self):
         lines = self.lines[:]
         for index in range(len(self.lines) - 1, -1, -1):
             if lines[index] == '':
-                del(lines[index])
+                del (lines[index])
             else:
                 break
         return lines

diff --git a/insights/parsers/uname.py b/insights/parsers/uname.py
@@ -445,7 +445,7 @@ def __ne__(self, other):
 
         See the `__eq__` operator for a detailed description.
         """
-        return not(self == other)
+        return not (self == other)
 
     def __lt__(self, other):
         """

diff --git a/insights/tests/parsers/test_satellite_postgresql_query.py b/insights/tests/parsers/test_satellite_postgresql_query.py
@@ -221,12 +221,12 @@ def test_basic_output_with_satellite_admin_setting():
 
 def test_satellite_admin_settings():
     settings = satellite_postgresql_query.SatelliteAdminSettings(context_wrap(SATELLITE_SETTINGS_2))
-    assert(len(settings)) == 2
+    assert (len(settings)) == 2
     assert not settings.get_setting('unregister_delete_host')
     assert settings.get_setting('destroy_vm_on_host_delete')
 
     settings = satellite_postgresql_query.SatelliteAdminSettings(context_wrap(SATELLITE_SETTINGS_3))
-    assert(len(settings)) == 2
+    assert (len(settings)) == 2
     assert not settings.get_setting('unregister_delete_host')
     assert not settings.get_setting('destroy_vm_on_host_delete')
     assert settings.get_setting('non_exist_column') is None