Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix attributes on toolbar #694

Merged
merged 3 commits into from
Mar 25, 2020
Merged

fix attributes on toolbar #694

merged 3 commits into from
Mar 25, 2020

Conversation

ryelo
Copy link
Member

@ryelo ryelo commented Mar 18, 2020

Widgets were being identified incorrectly and we need to put ids and attributes on the buttons

Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need to add IDs to elements other than help QE to identify them?

@codecov-io
Copy link

Codecov Report

Merging #694 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   60.81%   60.81%           
=======================================
  Files          45       45           
  Lines         855      855           
  Branches      165      165           
=======================================
  Hits          520      520           
  Misses        273      273           
  Partials       62       62           
Impacted Files Coverage Δ
src/js/App/Header/Tools.js 73.68% <ø> (ø)
src/js/App/Header/UserToggle.js 86.66% <ø> (ø)
src/js/App/Header/ToolbarToggle.js 52.94% <100.00%> (ø)

@karelhala
Copy link
Contributor

Re running travis!

@karelhala karelhala closed this Mar 25, 2020
@karelhala karelhala reopened this Mar 25, 2020
@karelhala karelhala merged commit f5f07cf into master Mar 25, 2020
@Hyperkid123 Hyperkid123 deleted the fixes/toolbar-attributes branch January 25, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants