Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load nav config for unauthed user. #1121

Merged

Conversation

Hyperkid123
Copy link
Contributor

@ryelo I got a question. Is this going to break openshift nav? Should we make an exception for that namepsace? I recall that even unauthed users can access the OCM.

jira: https://issues.redhat.com/browse/RHCLOUD-11627

@Hyperkid123 Hyperkid123 added bug Something isn't working don't merge labels Jan 13, 2021
@Hyperkid123 Hyperkid123 requested a review from a team January 13, 2021 09:50
@codecov-io
Copy link

codecov-io commented Jan 13, 2021

Codecov Report

Merging #1121 (033075b) into master (8f6683d) will increase coverage by 0.06%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1121      +/-   ##
==========================================
+ Coverage   53.01%   53.07%   +0.06%     
==========================================
  Files          65       65              
  Lines        1311     1315       +4     
  Branches      258      260       +2     
==========================================
+ Hits          695      698       +3     
- Misses        491      492       +1     
  Partials      125      125              
Impacted Files Coverage Δ
src/js/chrome/create-chrome.js 78.12% <80.00%> (-0.45%) ⬇️

@karelhala
Copy link
Contributor

@Hyperkid123 I don't think unauth users should have access to the OCM bundle. However they can access their bundle if they have no entitlements, which is still working.

@ryelo
Copy link
Member

ryelo commented Jan 14, 2021

Yeah, so @karelhala is partially correct. They have to be authed, but OCM doesn't care about an account number (which in the end is no entitlements). Whenever you get an entitlement, you get an account number. So, the OCM bundle, along with the trust page, should allow users with a 0, -1, or NaN account numbers but they still have an account and the getUser should still return an obj

@Hyperkid123
Copy link
Contributor Author

Hyperkid123 commented Jan 18, 2021

Seem like we have some new years date present.

NVM the Travis timezone has caught up.

@Hyperkid123 Hyperkid123 merged commit b0bc6f5 into RedHatInsights:master Jan 18, 2021
@Hyperkid123 Hyperkid123 deleted the stop-loading-nav-no-user branch January 18, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants