-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not load nav config for unauthed user. #1121
Do not load nav config for unauthed user. #1121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
+ Coverage 53.01% 53.07% +0.06%
==========================================
Files 65 65
Lines 1311 1315 +4
Branches 258 260 +2
==========================================
+ Hits 695 698 +3
- Misses 491 492 +1
Partials 125 125
|
@Hyperkid123 I don't think unauth users should have access to the OCM bundle. However they can access their bundle if they have no entitlements, which is still working. |
Yeah, so @karelhala is partially correct. They have to be authed, but OCM doesn't care about an account number (which in the end is no entitlements). Whenever you get an entitlement, you get an account number. So, the OCM bundle, along with the trust page, should allow users with a 0, -1, or NaN account numbers but they still have an account and the |
Seem like we have some new years date present. NVM the Travis timezone has caught up. |
@ryelo I got a question. Is this going to break openshift nav? Should we make an exception for that namepsace? I recall that even unauthed users can access the OCM.
jira: https://issues.redhat.com/browse/RHCLOUD-11627