Update global filter with new UX requests #1119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
==========================================
+ Coverage 52.92% 53.01% +0.08%
==========================================
Files 65 65
Lines 1315 1311 -4
Branches 259 258 -1
==========================================
- Hits 696 695 -1
+ Misses 493 491 -2
+ Partials 126 125 -1
|
| @@ -9,7 +9,7 @@ import { Chip, ChipGroup } from '@patternfly/react-core/dist/js/components/ChipG | |||
| import { Button } from '@patternfly/react-core/dist/js/components/Button'; | |||
| import { Tooltip } from '@patternfly/react-core/dist/js/components/Tooltip'; | |||
| import TagsModal from './TagsModal'; | |||
| import { workloads, updateSelected, storeFilter, generateFilter, selectWorkloads } from './constants'; | |||
| import { workloads, updateSelected, storeFilter, generateFilter } from './constants'; | |||
There was a problem hiding this comment.
I don't see the selectWorkloads to be used anywhere else. Can we delete the function declaration as well?
There was a problem hiding this comment.
| } | ||
| }, [selectedTags, isAllowed()]); | ||
|
|
||
| useEffect(() => { | ||
| const sapTag = workloads?.[0]?.tags?.[1]; | ||
| const sapTag = workloads?.[0]?.tags?.[0]; |
There was a problem hiding this comment.
I am just curious about this one. The SAP tag is always the first tag? And if so can this be refactored so it's a bit nicer on the eye?
There was a problem hiding this comment.
On the initial mocks, there was SAP and some other workload, hence the array. It's a static array passed from constants. I'm thinking about exporting just the SAP tag itself and bypass the workloads.
There was a problem hiding this comment.
Yeah, it would definitely make more sense. We can do it in a different PR though.
New updates to global filter
UX requested new things added to the global filter