Calculate only currently observed nav #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvsia
previously approved these changes
Oct 23, 2020
|
@karelhala can you fix the failing tests? |
karelhala
force-pushed
the
calculate-groupped-nav
branch
from
6925500
to
708f43c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to calculate nav of other bundles
When user is in one bundle navigation is also calculated for other bundle, this is not correct as it can make the navigation loading slow and unresponsive. This PR calculates only currently observed navigation and further reduces rendering of navigation. This is really obvious if you directly hit any URL without any cache. Once you navigate between apps it's not so obvious as we are using cached navigation.
Allow passing array of permissions
Some apps might require multiple checks before rendering navigation items so we have to check if permissions is array and not to wrap it in another array.