chore(RecommendationSystems): clear redux store on unmount

[mkholjuraev]

Description

Associated Jira ticket: # (issue)

Clears the inventory redux on unmount.

How to test the PR

Please include steps to test your PR.

Before the change

After the change

Dependent work link

Checklist:

• The commit message has the Jira ticket linked
• PR has a short description
• Screenshots before and after the change are added
• Tests for the changes have been added
• README.md is updated if necessary
• Needs additional dependent work

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
...yTabs/ConventionalSystems/RecommendationSystems.js	0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!

[bastilian]

Why does the Inventory store need to be cleared on unmount?

[mkholjuraev]

Why does the Inventory store need to be cleared on unmount?

This is needed to avoid cases when users change tabs, sometimes the content of the previous tab is shown in the next tab for milli-seconds.

[bastilian]

@mkholjuraev This feels like it is a workaround for something the Inventory does improperly. Maybe it would be better to investigate a proper fix/feature in the InventoryTable itself.

[mkholjuraev]

@bastilian yeah, it seems this prop is used to show initial loading state when the table is initially mounted. I have created a PR in the inventory to add it to immutable devices table

[AsToNlele]

LGTM, thanks for the clarification on the call 😄

[bastilian]

@mkholjuraev Then does the PR in inventory not make this PR obsolete?

[mkholjuraev]

@mkholjuraev Then does the PR in inventory not make this PR obsolete?
@bastilian yes it should be. I am making sure this is obsolete. If it is obsolete, I will close this PR.

[mkholjuraev]

Yup, this seems obsolete. Closing