Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref-RHINENG-9414 create dockerignore file #160

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Ref-RHINENG-9414 create dockerignore file #160

merged 1 commit into from
Apr 11, 2024

Conversation

r14chandra
Copy link
Collaborator

Why do we need this change? 💭

Create .dockerignore file

Documentation update? 📝

  • Yes
  • No

💂‍♂️ Checklist 🎯

  • Bugfix
  • New Feature
  • Refactor
  • Unittests Added
  • DRY code
  • Dependency Added
  • DB Migration Added

Additional 📣

Feel free to add any other relevant details such as links, notes, screenshots, here.

patilsuraj767
patilsuraj767 requested changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@patilsuraj767 patilsuraj767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do the reverse? instead of ignoring specific creds related file let us first ignore everything and then allow only the files which are needed to build the image. That way we will also reduce the build context.

@r14chandra
Copy link
Collaborator Author

Can we do the reverse? instead of ignoring specific creds related file let us first ignore everything and then allow only the files which are needed to build the image. That way we will also reduce the build context.

Sure, I will take a look at what can be ignored.

patilsuraj767
patilsuraj767 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@patilsuraj767 patilsuraj767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patilsuraj767 patilsuraj767 merged commit ca1a24d into RedHatInsights:master Apr 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patilsuraj767 patilsuraj767 patilsuraj767 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r14chandra @patilsuraj767