Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-9355 RHCID should be used when calling GetConnectionStatus #157

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

r14chandra
Copy link
Collaborator

Why do we need this change? 💭

Even though RHCID is the same as the SubscriptionManagerID, all (or most) hosts will have a SubscriptionManagerID even if they do not have a connection to Cloud Connector which can cause issues while getting connection status.

Documentation update? 📝

  • Yes
  • No

💂‍♂️ Checklist 🎯

  • Bugfix
  • New Feature
  • Refactor
  • Unittests Added
  • DRY code
  • Dependency Added
  • DB Migration Added

Additional 📣

Feel free to add any other relevant details such as links, notes, screenshots, here.

@r14chandra r14chandra requested review from subpop and dehort April 10, 2024 09:01
Copy link
Collaborator

@subpop subpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r14chandra
Copy link
Collaborator Author

/retest

@r14chandra
Copy link
Collaborator Author

Thanks for the review @subpop!

@r14chandra r14chandra merged commit 33bfc4d into RedHatInsights:master Apr 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants