RHINENG-8911 add pull_request_template #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r14chandra
changed the title
|
/retest |
|
Just a thought, do you think we need separate section about dependencies? I mean if changes require change in services which depends on config-manager and/or if config-manager depend on any changes from another services? |
we already have item added in checklist, so that can be used |
upadhyeammit
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint-commitschecks for every commit message of a PR to includefeat,fix, and others which I think is not required. Also, not checking the commit message to includeRHINENGwith a GitHub action as it might be possible that there is no card for a minor fix and there is also a possibility that a card is from a different project. So, we need to add conditional checks for card no. in the commit message which is not possible. It is good to include Github pull_request_template.md file.