Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref-RHINENG-8659 support cacert from clowder #146

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

r14chandra
Copy link
Collaborator

No description provided.

internal/config/config.go Outdated Show resolved Hide resolved
@r14chandra r14chandra requested a review from subpop March 15, 2024 08:04
internal/util/kafka.go Outdated Show resolved Hide resolved
internal/util/kafka.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@patilsuraj767 patilsuraj767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @r14chandra, I have setup kafka broker with custom ssl certs to review this PR. I have added the observations.

internal/util/kafka.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@patilsuraj767 patilsuraj767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patilsuraj767 patilsuraj767 merged commit 67d2767 into RedHatInsights:master Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants