-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref-RHINENG-8659 support cacert from clowder #146
Merged
patilsuraj767
merged 1 commit into
RedHatInsights:master
from
r14chandra:Ref-RHINENG-8659
Mar 18, 2024
Merged
Ref-RHINENG-8659 support cacert from clowder #146
patilsuraj767
merged 1 commit into
RedHatInsights:master
from
r14chandra:Ref-RHINENG-8659
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r14chandra
force-pushed
the
Ref-RHINENG-8659
branch
from
March 7, 2024 12:57
e07e0f8
to
0192797
Compare
subpop
reviewed
Mar 14, 2024
subpop
reviewed
Mar 15, 2024
patilsuraj767
requested changes
Mar 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @r14chandra, I have setup kafka broker with custom ssl certs to review this PR. I have added the observations.
r14chandra
force-pushed
the
Ref-RHINENG-8659
branch
from
March 18, 2024 04:47
1dd4fe8
to
1dc87ad
Compare
patilsuraj767
requested changes
Mar 18, 2024
r14chandra
force-pushed
the
Ref-RHINENG-8659
branch
from
March 18, 2024 07:40
1dc87ad
to
fbd37e6
Compare
patilsuraj767
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.