Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean Create/EditPolicy GraphQL implementation #2315

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Dec 19, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Also removes the usePolicy mutation hook.
And also clean up some tests like hooks.test.js.
@gkarat gkarat self-assigned this Dec 19, 2024
@gkarat gkarat requested a review from a team as a code owner December 19, 2024 14:41
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 51.61290% with 60 lines in your changes missing coverage. Please review.

Project coverage is 67.79%. Comparing base (e984fa1) to head (3f506e6).

Files with missing lines Patch % Lines
src/SmartComponents/EditPolicy/EditPolicy.js 5.26% 36 Missing ⚠️
src/SmartComponents/EditPolicy/EditPolicyForm.js 0.00% 14 Missing ⚠️
...c/SmartComponents/EditPolicy/EditPolicyRulesTab.js 56.52% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2315      +/-   ##
==========================================
- Coverage   68.07%   67.79%   -0.28%     
==========================================
  Files         357      347      -10     
  Lines        6471     6257     -214     
  Branches     2078     2025      -53     
==========================================
- Hits         4405     4242     -163     
+ Misses       2066     2015      -51     
Flag Coverage Δ
combined 67.79% <51.61%> (-0.28%) ⬇️
cypress 33.40% <33.33%> (+0.50%) ⬆️
jest 67.15% <51.61%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants