-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(container): Correct webpack binding in container #1023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in Slack: this prevents the proxy from being able to access a local API (i.e. localhost:3000 for compliance-backend); however, the dns issue seems to be resolved.
I investigated further the issue with the DNS servers and if the host OS uses systemd-resolved, podman copies containers/podman#3277 (comment) If we're not using host networking for the proxy, the API is basically inaccessible as it is running in a separate pod and podman doesn't support |
I think we can close this one. As @skateman says, we were hitting issues with new Fedora 33 'features' 😆 |
I'm still struggling with the frontend not listening on |
Ok, sure. @bastilian could we repurpose this PR to fix just the bind? |
48d42cc
to
39641bc
Compare
@skateman The binding should now work out of the box. |
39641bc
to
0e3cc73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0e3cc73
to
67f28c4
Compare
@@ -6,4 +6,6 @@ if [[ ! -d "/compliance/node_modules/@redhat-cloud-services" ]]; then | |||
cd /compliance; /usr/bin/npm install; | |||
fi | |||
|
|||
export IN_DOCKER='true'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the Docker compose documentation is not right. A environment variable defined in the .env file doesn't seem to overwrite the one in the compose file[1].
This corrects the binding behaviour of webpack dev server when it is running within a container.
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist