Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(navigation-secondary): rename rh-secondary-nav to `rh-navi… #746

Merged
merged 12 commits into from
Mar 2, 2023

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented Feb 27, 2023

What I did

  1. Renamed rh-secondary-nav to rh-navigation-secondary
  2. Renamed all sub-components rh-secondary-nav-* to rh-navigation-secondary-*
  3. Renamed all CSS custom properties --rh-secondary-nav-* to --rh-navigation-secondary-*

Reference: #695

Testing Instructions

  1. View deploy preview demo, dark variant demo, translation demo, deprecated demo

Notes to Reviewers

Look for any errors or broken functionality in the various demos.

@zeroedin zeroedin self-assigned this Feb 27, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2023

🦋 Changeset detected

Latest commit: 576d930

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 576d930
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/6400bea7d4f00c000844d985
😎 Deploy Preview https://deploy-preview-746--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zeroedin zeroedin marked this pull request as ready for review February 27, 2023 21:29
@bennypowers bennypowers enabled auto-merge (squash) February 28, 2023 08:42
.changeset/fifty-colts-cross.md Outdated Show resolved Hide resolved
@bennypowers bennypowers self-requested a review February 28, 2023 15:24
@bennypowers bennypowers merged commit acbb034 into main Mar 2, 2023
@bennypowers bennypowers deleted the refactor/navigation-secondary/rename branch March 2, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants