chore: tokens 2.1.1 #2106
chore: tokens 2.1.1 #2106
Conversation
🦋 Changeset detectedLatest commit: f537380 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: -1.33 kB (-0.64%) Total Size: 206 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
I think we should add the additional required CSS in the RTL demos as suggested in the tokens repo changeset
[lang=" he"] {
font-family: var(--rh-font-family-lang-he: "Noto Sans Hebrew");
}
We might also mention this explicitly in the changelog for RHDS @zhawkins, I believe you have mentioned that when we make changes to the dependencies, sometimes those changes feel as if they get lost in RHDS's changelog, do you have any opinions on how that would get called out?
There was a problem hiding this comment.
These changes look good.
It does look like there are still references to Noto * in a few other places like:
docs/get-started/index.md-<style>tagelements/rh-card/demo/color-context.html-<style>tagelements/rh-card/demo/sticky-pattern.html-<style>tagelements/rh-card/demo/title-pattern.html-<style>tagelements/rh-card/demo/variants.html-<style>tag- Should the Typography Foundations table list the other languages?
Thanks for your work on this.
If this is required, it's RHDS v3 |
|
Thanks for the work on this y'all!
🤔 I'm not really sure, you could use a star emoji? 😁 |
Maybe required was too strongly worded. If the failover to |
This should be a separate PR. I think it should be part of a base style sheet, and that stylesheet should be shared (i.e. adopted) into each element's shadow root as well. This is a separate issue and will require discussion. The first iteration should be quite minimal - lang, h1-6, p, a, etc. - no classes. |
Global styles are loaded in those documents
Sounds good to me |
| @@ -71,7 +71,7 @@ accommodate mixed-language content. For more technical details, go to the | |||
| <rh-table> | |||
|
|
|||
| | Language | Font family | | |||
| |----------|------------------------------| | |||
| | -------- | ---------------------------- | | |||
| | Chinese | Noto Sans Simplified Chinese | | |||
| | Japanese | Noto Sans Japanese | | |||
| | Korean | Noto Sans Korean | | |||
There was a problem hiding this comment.
Should we list the other languages here? Or nuke the table and have people refer to the font tokens page?
What I did
Testing Instructions