[POC] feat(navigation-secondary): poc for details summary #2060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for
navigation-secondary
served as a DSD templateWhat this POC is
navigation-secondary
.details > summary
as the key mechanism for the hamburger menu ofnavigation-secondary
and dropdownsnavigation-secondary
to be used as a DSD fragment (or SSR'd) that can be hydrated on the client.details > summary
standard mechanism.@media
queries to@container
queries. Likely improvements can be made to the implementation of a resize observer in lieu of using Screensize controller which only works withmatchMedia
navigation-primary
in the future as a mission critical component.What this POC is not
rh-navigation-secondary
instead creates a new componentrh-navigation-secondary-dsd
so they can be compared if necessary.1:1
with current nav, likely some variance that needs attention.dark
variantDemos
Example of artifacts being used in a no js state - Uncomment JS panel code to hydrate.
Deploy Preview - SSR'd and hydrated.
Known small caveats
compact
state as default, this causes a swap of styles between the hamburger compact style and desktop styles. Can maybe incorporate some animation which helps "hide" this jerky style swap.Todo
:marker
on safari, need safari specific style