chore: typescript assets in 11ty dev server and ssr #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bennypowers
force-pushed
the
chore/ts-assets-11ty-dev
branch
from
f67c197 to
22e4593
Compare
bennypowers
force-pushed
the
chore/ts-assets-11ty-dev
branch
from
22e4593 to
2067482
Compare
|
Size Change: -3.76 kB (-1.78%) Total Size: 207 kB
ℹ️ View Unchanged
|
bennypowers
requested review from
adamjohnson
and removed request for
adamjohnson
|
@adamjohnson @zeroedin PTAL, I managed a patch to jspm/generator which lets us ignore all local modules in the tracing process. |
|
Seeing some issues with the build. It seems initially a
Here's what's being output in my console FWIW: Initial https://app.warp.dev/block/OsOoMVvEhuT8xiUt5FxLUm After running |
|
When running
After these steps, I figured I would try something similar with
|
|
i wasn't able to reproduce on linux, i'll try on macos: |
|
@adamjohnson confirmed your issue on macOS, but oddly it doesn't happen on linux 🤷 Either way, bumping to node 23 seems to have done the job, so 🤞 PTAL |
zeroedin
reviewed
Nov 12, 2024
zeroedin
reviewed
Nov 12, 2024
There was a problem hiding this comment.
It doesn't appear the files ever get created in _site/assets/packages/@rhds/elements/ or _site/assets/packages/@uxdot/elements/ My assumption is while running npm run serve that these files get created on the fly, but when needed for CI and a static site they aren't available, most likely related to previous build comment.
zeroedin
reviewed
Nov 12, 2024
I tested these on both OSX and Linux Mint. Anecdotally, it takes 11 seconds for a docs change on my M2 MBP. It takes ~50 seconds for a docs change on my personal Dell laptop from 2018. The difference in speed on the Apple silicone is real. I wonder if anyone has a Windows machine they'd be willing to test with? I unfortunately do not have a Windows device. |
Unless someone asks, and gives a compelling reason why we should care, I really don't want to support windows for our development workflow. They can use WSL, a vm, a container, online services like gh codespaces, whatever. |
zeroedin
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
migrate all elements to new standardreverted this because for reasons i care not to know, it breaks the build's performance in a serious way.accessorsyntax for standard decorators/ts5.0 (might spin this into a separate pr)So now the 11ty dev server and the wds dev server operate entirely on typescript sources, with no build. the only time we compile is during the docs build so we can copy files over, and in the 'build' script so we can ship js files.
Testing Instructions
npm run serveandnpm run buildNotes to Reviewers
In it's current state (thursday morning, Jerusalem time), the build has been going for 14 hours, and after 50 pages or so, pages take 30 minutes each to build. Clearly there's a leak or other perf issue somewhere.