Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audio-player) corrected focused on menu button after escape pressed #1869

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix(audio-player) corrected focused on menu button after escape pressed #1869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70daad2
fix(audio-player): return focus to menu button when escape is pressed…
zeroedin Sep 16, 2024
b9f9e2c
chore(audio-player): add changeset
zeroedin Sep 16, 2024
68161f4
chore(audio-player): changeset typo
zeroedin Sep 16, 2024
49b64fd
Merge branch 'staging/clefairy' into fix/audio-player/aria-hidden-on-…
zeroedin Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/big-glasses-drum.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rhds/elements": patch
---

`<rh-audio-player>`: corrected focus when keyboard navigating options menu
1 change: 1 addition & 0 deletions elements/rh-audio-player/rh-audio-player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,7 @@ export class RhAudioPlayer extends LitElement {
async #onMenuKeydown(event: KeyboardEvent) {
if (event.key === 'Escape') {
await this.#hideMenu();
this.shadowRoot?.querySelector<HTMLButtonElement>('#menu-button')?.focus();
}
}

Expand Down
Loading