Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(back-to-top): position #1816

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(back-to-top): position #1816

merged 1 commit into from
Sep 3, 2024

Conversation

bennypowers
Copy link
Member

What I did

  1. apply the guidelines to back-to-top
  2. remove the (undocumented, and bad for l10n) position css props

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: c1bf97c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit c1bf97c
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/66d706bca20da0000815a24a
😎 Deploy Preview https://deploy-preview-1816--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Size Change: 0 B

Total Size: 180 kB

ℹ️ View Unchanged
Filename Size
./elements.js 463 B
./elements/rh-accordion/context.js 162 B
./elements/rh-accordion/rh-accordion-header.js 2.82 kB
./elements/rh-accordion/rh-accordion-panel.js 1.5 kB
./elements/rh-accordion/rh-accordion.js 3.49 kB
./elements/rh-alert/rh-alert.js 5.44 kB
./elements/rh-audio-player/rh-audio-player-about.js 1.68 kB
./elements/rh-audio-player/rh-audio-player-button.css.js 428 B
./elements/rh-audio-player/rh-audio-player-panel.css.js 554 B
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 1.51 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js 1.01 kB
./elements/rh-audio-player/rh-audio-player.js 14.4 kB
./elements/rh-audio-player/rh-cue.js 2.01 kB
./elements/rh-audio-player/rh-transcript.js 2.3 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 2.92 kB
./elements/rh-back-to-top/rh-back-to-top.js 2.1 kB
./elements/rh-badge/rh-badge.js 1.04 kB
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-breadcrumb/rh-breadcrumb.js 1.58 kB
./elements/rh-button/rh-button.js 4.47 kB
./elements/rh-card/rh-card.js 3.16 kB
./elements/rh-code-block/rh-code-block.js 5.62 kB
./elements/rh-cta/rh-cta.js 4.18 kB
./elements/rh-dialog/rh-dialog.js 4.8 kB
./elements/rh-dialog/yt-api.js 617 B
./elements/rh-footer/rh-footer-block.js 770 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.17 kB
./elements/rh-footer/rh-footer-social-link.js 967 B
./elements/rh-footer/rh-footer-universal.js 2.04 kB
./elements/rh-footer/rh-footer.css.js 2.16 kB
./elements/rh-footer/rh-footer.js 3.01 kB
./elements/rh-health-index/rh-health-index.js 2.38 kB
./elements/rh-icon/rh-icon.js 2.33 kB
./elements/rh-icon/ssr.js 181 B
./elements/rh-menu/rh-menu.js 1.2 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.49 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.35 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.76 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 5.46 kB
./elements/rh-navigation-secondary/test/fixtures.js 769 B
./elements/rh-pagination/rh-pagination.js 5.53 kB
./elements/rh-site-status/rh-site-status.js 3.08 kB
./elements/rh-skip-link/rh-skip-link.js 1.13 kB
./elements/rh-spinner/rh-spinner.js 1.44 kB
./elements/rh-stat/rh-stat.js 2.21 kB
./elements/rh-subnav/rh-subnav.js 2.84 kB
./elements/rh-surface/rh-surface.js 868 B
./elements/rh-switch/rh-switch.js 3.16 kB
./elements/rh-table/rh-sort-button.js 1.49 kB
./elements/rh-table/rh-table.js 2.97 kB
./elements/rh-tabs/context.js 160 B
./elements/rh-tabs/rh-tab-panel.js 1.15 kB
./elements/rh-tabs/rh-tab.js 3.04 kB
./elements/rh-tabs/rh-tabs.js 3.74 kB
./elements/rh-tag/rh-tag.js 2.16 kB
./elements/rh-tile/rh-tile-group.js 1.81 kB
./elements/rh-tile/rh-tile.js 5.09 kB
./elements/rh-timestamp/rh-timestamp.js 983 B
./elements/rh-tooltip/rh-tooltip.js 2.24 kB
./elements/rh-video-embed/rh-video-embed.js 4.64 kB
./lib/context/color/consumer.js 1.16 kB
./lib/context/color/context-color.css.js 268 B
./lib/context/color/controller.js 885 B
./lib/context/color/provider.js 2.04 kB
./lib/context/event.js 583 B
./lib/context/headings/consumer.js 722 B
./lib/context/headings/controller.js 1.12 kB
./lib/context/headings/provider.js 1.24 kB
./lib/DirController.js 565 B
./lib/elements/rh-context-demo/rh-context-demo.js 1.18 kB
./lib/elements/rh-context-picker/rh-context-picker.js 2.21 kB
./lib/environment.js 4.07 kB
./lib/functions.js 175 B
./lib/I18nController.js 1.38 kB
./lib/ScreenSizeController.js 849 B
./react/rh-accordion/rh-accordion-header.js 199 B
./react/rh-accordion/rh-accordion-panel.js 185 B
./react/rh-accordion/rh-accordion.js 215 B
./react/rh-alert/rh-alert.js 184 B
./react/rh-audio-player/rh-audio-player-about.js 191 B
./react/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 214 B
./react/rh-audio-player/rh-audio-player-subscribe.js 196 B
./react/rh-audio-player/rh-audio-player.js 183 B
./react/rh-audio-player/rh-cue.js 195 B
./react/rh-audio-player/rh-transcript.js 207 B
./react/rh-avatar/rh-avatar.js 173 B
./react/rh-back-to-top/rh-back-to-top.js 183 B
./react/rh-badge/rh-badge.js 174 B
./react/rh-blockquote/rh-blockquote.js 179 B
./react/rh-breadcrumb/rh-breadcrumb.js 179 B
./react/rh-button/rh-button.js 174 B
./react/rh-card/rh-card.js 172 B
./react/rh-code-block/rh-code-block.js 181 B
./react/rh-cta/rh-cta.js 170 B
./react/rh-dialog/rh-dialog.js 203 B
./react/rh-footer/rh-footer-block.js 184 B
./react/rh-footer/rh-footer-copyright.js 187 B
./react/rh-footer/rh-footer-links.js 185 B
./react/rh-footer/rh-footer-social-link.js 193 B
./react/rh-footer/rh-footer-universal.js 188 B
./react/rh-footer/rh-footer.js 174 B
./react/rh-health-index/rh-health-index.js 184 B
./react/rh-icon/rh-icon.js 202 B
./react/rh-menu/rh-menu.js 173 B
./react/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 217 B
./react/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 205 B
./react/rh-navigation-secondary/rh-navigation-secondary-menu.js 199 B
./react/rh-navigation-secondary/rh-navigation-secondary-overlay.js 201 B
./react/rh-navigation-secondary/rh-navigation-secondary.js 213 B
./react/rh-pagination/rh-pagination.js 178 B
./react/rh-site-status/rh-site-status.js 181 B
./react/rh-skip-link/rh-skip-link.js 181 B
./react/rh-spinner/rh-spinner.js 175 B
./react/rh-stat/rh-stat.js 171 B
./react/rh-subnav/rh-subnav.js 175 B
./react/rh-surface/rh-surface.js 175 B
./react/rh-switch/rh-switch.js 185 B
./react/rh-table/rh-sort-button.js 213 B
./react/rh-table/rh-table.js 174 B
./react/rh-tabs/rh-tab-panel.js 181 B
./react/rh-tabs/rh-tab.js 187 B
./react/rh-tabs/rh-tabs.js 174 B
./react/rh-tag/rh-tag.js 182 B
./react/rh-tile/rh-tile-group.js 183 B
./react/rh-tile/rh-tile.js 194 B
./react/rh-timestamp/rh-timestamp.js 176 B
./react/rh-tooltip/rh-tooltip.js 175 B
./react/rh-video-embed/rh-video-embed.js 227 B

compressed-size-action

Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links Goes To Main

@bennypowers bennypowers merged commit f4fcd78 into main Sep 3, 2024
8 checks passed
@bennypowers bennypowers deleted the fix/back-to-top/guidelines branch September 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

3 participants